Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subconversation ID to RemoteMLSMessage #3270

Merged
merged 4 commits into from
May 8, 2023
Merged

Add subconversation ID to RemoteMLSMessage #3270

merged 4 commits into from
May 8, 2023
+65 −1

Conversation

stefanwire
Copy link
Contributor

@stefanwire stefanwire commented May 4, 2023 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

See also #3271.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 4, 2023
@stefanwire stefanwire mentioned this pull request May 8, 2023
Merged
2 tasks
@stefanwire stefanwire marked this pull request as ready for review May 8, 2023 08:00
pcapriotti
pcapriotti approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the new test should go into the new integration package.

@stefanwire stefanwire merged commit b51b75b into mls May 8, 2023
@stefanwire stefanwire deleted the FS-1868 branch May 8, 2023 08:29
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanwire @pcapriotti @zebot